----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113152/ -----------------------------------------------------------
(Updated Feb. 26, 2017, 12:37 a.m.) Status ------ This change has been discarded. Review request for kde-workspace. Repository: kde-workspace Description ------- Using the date selector in kcm_clock to set any date further than February 7, 2106 resulted in setting the time to ((time_t) (unsigned int) -1). This patch makes setting any date further than this to spit out an DateError. Also, it's a seed for discussion regarding this KCM module as passing the values as QStrings and converting from/to time_t doesn't seem like a manageable solution to the problem. Thanks for your opinions. Diffs ----- kcontrol/dateandtime/dtime.cpp 518afe5 kcontrol/dateandtime/helper.cpp 9168db3 Diff: https://git.reviewboard.kde.org/r/113152/diff/ Testing ------- Built and tested on Fedora 19 x86_64. Thanks, Martin Bříza