----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130193/#review103463 -----------------------------------------------------------
Ship it! While at it, please also remove the arguments from the else() and endif() calls. - Rolf Eike Beer On Juli 20, 2017, 7:59 nachm., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130193/ > ----------------------------------------------------------- > > (Updated Juli 20, 2017, 7:59 nachm.) > > > Review request for kdelibs and Frank Osterfeld. > > > Repository: kdelibs > > > Description > ------- > > Otherwise it errors out with: > "CMake Error at kdeui/CMakeLists.txt:316 (else): A duplicate ELSE > command was found inside an IF block." > Also adjust indentation to match the surrounding lines. > > > Diffs > ----- > > kdeui/CMakeLists.txt d6ec8b47e9af686441ab5ab761be9ff424cbb556 > > Diff: https://git.reviewboard.kde.org/r/130193/diff/ > > > Testing > ------- > > Builds fine with cmake-3.9.0. > > > Thanks, > > Heiko Becker > >
