> On July 31, 2017, 9:11 a.m., Kevin Funk wrote: > > processui/ksysguardprocesslist.cpp, line 354 > > <https://git.reviewboard.kde.org/r/128854/diff/3/?file=498252#file498252line354> > > > > Why this?
When I try to capture "d", then I get the following compiler error: processui/ksysguardprocesslist.cpp:355:36: error: capture of non-variable ‘KSysGuardProcessList::d’ I also find the current solution a bit strange. See here: https://stackoverflow.com/questions/12944002/capture-by-value-class-members (C++14 might solve the issue) - Gregor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/#review103512 ----------------------------------------------------------- On July 28, 2017, 12:20 p.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128854/ > ----------------------------------------------------------- > > (Updated July 28, 2017, 12:20 p.m.) > > > Review request for KDE Base Apps, Martin Flöser, John Tapsell, Ken Vermette, > Thomas Lübking, and Thomas Pfeiffer. > > > Repository: libksysguard > > > Description > ------- > > This adds a new "Tools" button to the ksysguard widget which contains entries > to related tools: > > - Run Command --> starts KRunner to execute a command > - KSysguard --> starts KSysguard (this is useful because Ctrl+Esc only starts > the lightweight System Monitor which has less features) > - Info Center --> starts the Info Center which shows additional system > information > - Htop --> starts htop > - Kill a window (Ctrl+Alt+Esc) --> triggers the KWin kill window function. > The displayed shortcut is the one set in Global Keyboard Shortcuts. > Currently, this shortcut is shown in the End Process... button tooltip but > there it is hard-coded. > > This RR replaces this old RR https://git.reviewboard.kde.org/r/122249/ > > > Diffs > ----- > > CMakeLists.txt 84a447990563cf1605c06989b255627e99ef31b3 > processui/CMakeLists.txt 1927839282a6282c824f5bbb5d35ea94075f428e > processui/ProcessWidgetUI.ui e50f55cf1813b00d49b1716023df487ffbd536e3 > processui/ksysguardprocesslist.cpp 79e9bb3c4e9d481a03d2e5992ab1c0692a06de28 > > Diff: https://git.reviewboard.kde.org/r/128854/diff/ > > > Testing > ------- > > - test if all tools start correctly > - check if a changed shortcut for Kill Window is shown in the tools menu (see > screenshot) > - check if for example htop is not installed that there is no menu item for it > > > File Attachments > ---------------- > > screenshot of the new Tools button > > https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png > > > Thanks, > > Gregor Mi > >
