> On Sept. 26, 2017, 8:02 p.m., Albert Astals Cid wrote: > > cmake/modules/Win32Macros.cmake > > Lines 61 (patched) > > <https://git.reviewboard.kde.org/r/130239/diff/2/?file=513534#file513534line61> > > > > I don't think it makes sense adding a new public-ish macro in 4.14.lots > > Ralf Habacker wrote: > See revision 1 of this patch at > https://git.reviewboard.kde.org/r/130239/diff/1/ > > Albert Astals Cid wrote: > I'm personally happier with that patch for almost dead 4.14 (it has 2 > releases left), now you're going to need someone with a win32 build/knowledge > to approve since honestly i have no idea what this does. > > Ralf Habacker wrote: > > for almost dead 4.14 (it has 2 releases left), > > Looking at the number of open KF5 related windows issues I guess kmymoney > and umbrello for Windows will depends on KDE4 at least a year. > > >i have no idea what this does. > > From > https://stackoverflow.com/questions/20096706/how-does-windows-decide-whether-to-display-the-uac-prompt > > kconf_update is "hitting a Windows Installer Detection Technology > compatibility heuristic. Windows will try to detect when an application is an > installer, and probably needs to be elevated." > > BTW: The same issue happens also with KF5 > > Alexey Min wrote: > This looks good and harmless actually. As I understood, it adds a .rc > (windows resource file) with embedded manifest resource, saying that no > elevation is needed for this .exe file. > We at our work also had problems with this windows heuristic (we had a > helper program, containing "setup" in its name, so it magically required > administrator rights with no real need for this). > So if this really works and helps for windows, why not. > > Albert Astals Cid wrote: > > Looking at the number of open KF5 related windows issues I guess > kmymoney and umbrello for Windows will depends on KDE4 at least a year. > > That has nothing to do with kdelibs 4.14.x not being released anymore > after KDE Applications 17.08.3, which is what i said > > Luigi Toscano wrote: > Also, most of the "KF5 issues" for umbrello (for example) are mostly > related to cross-compilation and co-installability (which should not care, > once you have the KF5 version you ignore the other), so not blocker for the > release: > https://bugs.kde.org/showdependencytree.cgi?id=373932&hide_resolved=0 > Some are related to icons (so probably something with Qt). Anyway, most > of the "issues" are not real issue for a pure KF5 release with an independent > installer. > I bet on way less than one year. But again, it is out of scope for this.
> So if this really works and helps for windows, why not. so please press ship it > But again, it is out of scope for this where could we discuss such issues ? - Ralf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130239/#review103738 ----------------------------------------------------------- On Sept. 27, 2017, 11:19 a.m., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130239/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 11:19 a.m.) > > > Review request for kdelibs and Albert Astals Cid. > > > Bugs: 384334 > http://bugs.kde.org/show_bug.cgi?id=384334 > > > Repository: kdelibs > > > Description > ------- > > This patch fixes an issue that on the first start of KMyMoney (and on some > computers on every start for example reported by > https://forum.kde.org/viewtopic.php?f=69&t=141673&sid=ba4dcaa26018f16e19d21c58c34ad4e9) > on running kconf_update the user account control pops up and forces the user > to allow or deny this application. > > Commit message > > Add Windows manifest to kconf_update.exe > > This explicitly sets the execution level to 'asInvoker', preventing > Windows' UAC heuristics from deciding that because its name mentions > "update", it probably needs to escalate privileges. > > FIXED-IN:4.14.36 > BUG:384334 > > > Diffs > ----- > > kconf_update/CMakeLists.txt 6bf3bf1f923baf11aad63e10fe249d70ce1b4d33 > > > Diff: https://git.reviewboard.kde.org/r/130239/diff/3/ > > > Testing > ------- > > Compiled at > https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-kdelibs4 > and tested with KMyMoney snapshot for Windows downloadable from > https://software.opensuse.org/package/mingw32-kmymoney-portable > > > Thanks, > > Ralf Habacker > >