On Sonntag, 14. April 2019 12:44:20 CEST Adriaan de Groot wrote: > On Saturday, 13 April 2019 14:08:18 CEST Martin Koller wrote: > > > # License issues > > > > > > None, actually. Well done. Consistent use of GPLv3+ everywhere. You might > > > want to add SPDX identifiers, but that would be the icing on the cake. > > > > Where, which and how would I need to add SPDX identifiers ? > > You don't *need* to. Like I said, icing on the cake, which is like .. vanilla > sauce on the apfelstruedel. Makes it complete and wonderful, but it's > acceptable without it. > > SPDX identifiers are machine-readable, standardised, tags in source files > that > help tooling that works with licensing (meta) data. See spdx.org; something > like (off the top of my head, not necessarily the right identifier or format, > etc.) > > // SPDX-Identifier: GPLv2+ > > at the top of C++ source files does the trick.
ok, done. > > Where is this documented in KDE guidelines ? > > Here > > https://community.kde.org/Policies/Licensing_Policy > > I don't find anything. > > It's not. should it ? > > > # Compatibility issues > > > > > > Fails to document that NetworkManager and BlueZ are required. > > > > Not sure I understand. > > Would have been nice to have that in the README, is what I mean. I'm not a fan of doing duplicate things. The cmake file is the ultimate source for specifying what the application depends on. Adding this somewhere else will easily get out of sync. -- Best regards/Schöne Grüße Martin A: Because it breaks the logical sequence of discussion Q: Why is top posting bad? () ascii ribbon campaign - against html e-mail /\ - against proprietary attachments Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at
