El dissabte, 28 de setembre de 2019, a les 13:01:11 CEST, Volker Krause va
escriure:
> Hi,
>
> ELF Dissector has been moved to kdereview for the usual review process.
>
It doesn't build for me, i need
-#include <capstone.h>
+#include <capstone/capstone.h>
Because my include is in
/usr/include/capstone/capstone.h
and
pkg-config --cflags capstone
returns empty.
clang-tidy says
src/ui/mainwindow.cpp:120:29: error: std::move of the const variable
'fileName' has no effect; remove std::move() or make the variable non-const
[performance-move-const-arg,-warnings-as-errors]
m_currentFileName = std::move(fileName);
So
- const auto fileName =
settings.value(QStringLiteral("Recent/PreviousFile")).toString();
+ auto fileName =
settings.value(QStringLiteral("Recent/PreviousFile")).toString();
i guess?
src/lib/checks/ldbenchmark.cpp:161:20: error: Value stored to 'file' during
its initialization is never read
[clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
const auto file = m_fileSet->file(m_results.size() - 1 - i);
src/lib/printers/relocationprinter.cpp:416:8: error: Excessive padding in
'struct RelocTypeRepository' (8 padding bytes, where 0 is optimal).
Optimal fields order:
typeInfos,
machine,
typeInfosSize,
consider reordering the fields or adding explicit padding members
[clang-analyzer-optin.performance.Padding,-warnings-as-errors]
(Annoying i know, but isn't elf-dissector a bit about this padding things
too?)
Also you have a few deprecated Qt calls.
Cheers,
Albert
>
> Thanks,
> Volker
