On Wed, Apr 7, 2021 at 11:50 PM Piyush Aggarwal <piyushaggarwal...@gmail.com> wrote:
> > > On Wed, Apr 7, 2021 at 3:04 PM Piyush Aggarwal < > piyushaggarwal...@gmail.com> wrote: > >> I'll get right on it >> >> On Wed, 7 Apr, 2021, 3:02 pm Ben Cooksley, <bcooks...@kde.org> wrote: >> >>> Hi all, >>> >>> Recently changes were made to kdeconnect-kde that introduced new >>> dependencies that broke the build on Windows. >>> >> > This should be fixed by the > https://invent.kde.org/network/kdeconnect-kde/-/commit/80178b8ff80c1e42692b309880d6f1435c62ce4e > . Please poke the CI once so I can be sure. > Thanks. I've taken a look and it appears that it has corrected the build failure - which means we are now in the same situation as earlier, where the testing phase cleans up the dbus-daemon processes that are launched by the CMake configure phase (which stops it from breaking the node entirely, but is still not perfect) > > >>> While this in itself is an issue, it has exposed a much more significant >>> issue which requires urgent remediation as it breaks any Windows build node >>> that attempts to carry out a build of kdeconnect. These breakages require >>> manual Sysadmin intervention to correct. >>> >> > This issue needs to be fixed appropriately. I wrote a way to kill > dbus-daemon.exe with Win APIs in the kdeconnect-kde source, used here: > https://github.com/KDE/kdeconnect-kde/blob/master/indicator/main.cpp#L106 > . The Function's definition is here: > https://github.com/KDE/kdeconnect-kde/blob/master/indicator/indicatorhelper_win.cpp#L48 > . Please let me know if I can be of help and integrate it somewhere in > Craft/ the CI. > The C++ code is completely innocent in this case, one of the checks being run by CMake as part of the configure-time step is the cause of this issue. Do you have any kdeconnect-kde specific checks in there that call custom binaries / code to search for specific dependencies by any chance? > > As this creates persistent issues for other projects and because a new >>> dependency was introduced without notification, the following is notice >>> that Windows CI support for kdeconnect-kde will be terminated in 12 hours >>> time should steps to resolve this not be taken. >>> >> > I apologize for the mishap and the inconvenience caused to the other > projects. This was not intended. > > Best > Piyush Aggarwal > from the KDE Connect Team > > Thanks, Ben
