On Sunday 07 November 2010 16:02:41 Albert Astals Cid wrote: > A Dissabte, 6 de novembre de 2010, Milian Wolff va escriure: > > Hey all, > > > > I'm not sure on what the procedure is to have a project on git.kde.org be > > review (am I supposed to move it somehow to a "kdereview" module?). So I > > just shoot at the dark and announce it here directly: > > > > Please review Massif Visualizer for inclusion in KDE Extra Gear SDK: > > https://projects.kde.org/massif-visualizer > > > > It works rather well for me and apparently other people. It's (since > > yesterday) possible to use it on Mac OSX as well, a ports file was posted > > by a user for inclusion in MacPorts. > > > > Any kind of code review would be appreciated, parts that I know could be > > improved (just not sure how): > > > > - i18n: Albert, I think you said that I have some strange strings, could > > you tell me which? > > well, i don't remember exactly our casing rules but things like > i18n("toggle total cost graph") > i18n("toggle detailed cost graph") > i18n("focus most expensive node") > and others, seem like should have at least the first letter in capital > casing.
so, can someone clarify? Should I upper case those actions? Bye -- Milian Wolff m...@milianw.de http://milianw.de
signature.asc
Description: This is a digitally signed message part.
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
