-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115877/#review52215
-----------------------------------------------------------


This review has been submitted with commit 
d4b9eadc544404ee488668af8f5bfa1321f2e614 by Raphael Kubo da Costa to branch 
KDE/4.13.

- Commit Hook


On Feb. 18, 2014, 10:48 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115877/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 10:48 p.m.)
> 
> 
> Review request for Baloo and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> This is patch 1/2 of making the extended attributes support work on
> non-Linux operating systems, and covers the build-system changes.
> 
> Replace the Linux-specific FindXAttr.cmake with a more standard
> ConfigureChecks.cmake that looks for extended attributes-related headers in
> multiple locations to account for multiple operating system implementations.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindXattr.cmake 530eb6ddba45149fe86e04ca6c5154471a2e0272 
>   CMakeLists.txt d9be10f5b5f89205ab09a81ed0afc016238d5b7d 
>   ConfigureChecks.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115877/diff/
> 
> 
> Testing
> -------
> 
> I stop getting fatal errors on FreeBSD due to the Linux xattr headers not 
> being found.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Reply via email to