----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116701/#review52693 -----------------------------------------------------------
Ship it! Thanks! - Vishesh Handa On March 10, 2014, 11:12 p.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116701/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 11:12 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > XattrDetector is a QObject-derived class, so keeping a global static object > around is dangerous. > > > Diffs > ----- > > src/file/lib/filecustommetadata.cpp > e63f34662400c5f1e36a458af10d6c6d7b0f65a2 > > Diff: https://git.reviewboard.kde.org/r/116701/diff/ > > > Testing > ------- > > Nothing exploded, everything built and all tests keep passing. > > > Thanks, > > Raphael Kubo da Costa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
