-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116919/#review53634
-----------------------------------------------------------



src/file/filewatch.cpp
<https://git.reviewboard.kde.org/r/116919/#comment37648>

    Are you sure this compiles?



src/file/metadatamover.h
<https://git.reviewboard.kde.org/r/116919/#comment37647>

    I'm confused. Why remove this function?


- Vishesh Handa


On March 20, 2014, 4:15 p.m., Nitul Datt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116919/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 4:15 p.m.)
> 
> 
> Review request for Baloo and Vishesh Handa.
> 
> 
> Bugs: 329039 and bug
>     http://bugs.kde.org/show_bug.cgi?id=329039
>     http://bugs.kde.org/show_bug.cgi?id=bug
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Removed the internal queue from metadatamover. Now, events are processed as 
> they arrive.
> 
> 
> Diffs
> -----
> 
>   src/file/metadatamover.cpp 14d454a 
>   src/file/metadatamover.h d7975ec 
>   src/file/CMakeLists.txt c5dba49 
>   src/file/filewatch.cpp c0ccf72 
>   src/file/updaterequest.h 1844dff 
>   src/file/updaterequest.cpp 63dd9c5 
> 
> Diff: https://git.reviewboard.kde.org/r/116919/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitul Datt
> 
>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Reply via email to