> On April 12, 2014, 1:57 a.m., Kevin Krammer wrote: > > src/file/kcm/folderselectionwidget.cpp, line 210 > > <https://git.reviewboard.kde.org/r/117436/diff/1/?file=263434#file263434line210> > > > > p is a rather bad variable name :) > > the question is what does this check protect against? > > Might be easier to check if "url" is a prefix of QDir::homePath() if > > this protects against $HOME being excluded
Yes it is :) I just had it in there to easily check the result - changed to "if (url == homeRoot())" now. What the code does is check if the user is adding the home root dir to the exclude list, if so it changes it to homePath. Why it does this, I don't know - you'll have to ask Vishesh that. - Lindsay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/#review55461 ----------------------------------------------------------- On April 8, 2014, 11 p.m., Lindsay Mathieson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117436/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 11 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > Part of the KCM code assumes the users home dir is under "/home", which is > not always the cause in linux - e.g OpenSUSE with AD Authentication uses a > /home/DOMAIN hierarchy. Other systems use /opt. Not to mention windows etc. > > The code adds a function homeRoot() which returns the parent directory of the > uses home directory. > > > Diffs > ----- > > src/file/kcm/folderselectionwidget.cpp bc87a33 > > Diff: https://git.reviewboard.kde.org/r/117436/diff/ > > > Testing > ------- > > Built, installed. Adding paths to the exclude lists still recognise the home > root. > > > Thanks, > > Lindsay Mathieson > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
