> On April 13, 2014, 4 a.m., Vishesh Handa wrote: > > src/file/kcm/folderselectionwidget.cpp, line 295 > > <https://git.reviewboard.kde.org/r/117420/diff/2-3/?file=263314#file263314line295> > > > > I've given this more thought, and I dislike the '~/'. Please remove it. > > > > The rest is fine. > > > > I can ask for an exception from the release team and ship this with 4.13
Trouble is, if you then add $HOME as an exclude path it just displays the Home Icon and no string at all. Would "HomeIcon/" be better? - Lindsay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117420/#review55527 ----------------------------------------------------------- On April 8, 2014, 9:52 p.m., Lindsay Mathieson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117420/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 9:52 p.m.) > > > Review request for Baloo. > > > Bugs: 333155 > http://bugs.kde.org/show_bug.cgi?id=333155 > > > Repository: baloo > > > Description > ------- > > Displays full path of excluded directories - reduce possibilities of > confusion and ambiguity. > > > Diffs > ----- > > src/file/kcm/folderselectionwidget.h 5e4e661 > src/file/kcm/folderselectionwidget.cpp bc87a33 > > Diff: https://git.reviewboard.kde.org/r/117420/diff/ > > > Testing > ------- > > Build, installed - opens KCM module, full paths displayed, with ample room. > > > Thanks, > > Lindsay Mathieson > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
