-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117930/
-----------------------------------------------------------
(Updated May 3, 2014, 7:51 a.m.)
Status
------
This change has been marked as submitted.
Review request for Baloo.
Bugs: 333763
http://bugs.kde.org/show_bug.cgi?id=333763
Repository: baloo
Description
-------
https://bugs.kde.org/show_bug.cgi?id=333763 shows that the Xapian database
constructor can throw an exception, which is not handled at the moment. This
patch wraps all Xapian-related stuff in Baloo::FileFetchJob::doStart() in a try
{...} block and catches all exceptions.
The alternative would be to only add a catch statement for the
Xapian::DatabaseOpeningError which seems to be thrown according to the bug
report, provided that we can be 100% sure that no other exceptions can be
thrown there. IMHO, a library that uses external libraries that can throw
exceptions should try as hard as possible to catch all exceptions.
Diffs
-----
src/file/lib/filefetchjob.cpp 21f5520
Diff: https://git.reviewboard.kde.org/r/117930/diff/
Testing
-------
Unit tests still pass.
Thanks,
Frank Reininghaus
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
