> On July 18, 2014, 10:33 a.m., Vishesh Handa wrote: > > I'm fine with this change. Baloo will eventually become a framework, we may > > as well get the process started.
Sure, but this is not the way to get the process started. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119319/#review62643 ----------------------------------------------------------- On July 16, 2014, 12:41 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119319/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 12:41 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > Most frameworks install their plugins to > ```${PLUGINS_INSTALL_DIR}/kf5/$FRAMEWORK```. I think it's better than > polluting the qt5/plugins directory with $framework_pluginname.so binaries, > so let Baloo install it's store plugins into > ```${PLUGIN_INSTALL_DIR}/kf5/baloo/``` and without the ```baloo_``` prefix > > > Diffs > ----- > > src/file/search/CMakeLists.txt 1bf2160 > src/file/search/baloo_filesearchstore.desktop e8a4689 > src/pim/search/calendar/CMakeLists.txt 5542203 > src/pim/search/calendar/baloo_calendarsearchstore.desktop 898925a > src/pim/search/contact/CMakeLists.txt bf63f8f > src/pim/search/contact/baloo_contactsearchstore.desktop 42edf10 > src/pim/search/email/CMakeLists.txt 35757e4 > src/pim/search/email/baloo_emailsearchstore.desktop 65dea8e > src/pim/search/note/CMakeLists.txt 0fe03b5 > src/pim/search/note/baloo_notesearchstore.desktop c11e28e > > Diff: https://git.reviewboard.kde.org/r/119319/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
