> On Juli 25, 2014, 12:04 nachm., Vishesh Handa wrote: > > src/file/autotest/filemonitortest.h, line 37 > > <https://git.reviewboard.kde.org/r/119459/diff/1/?file=292598#file292598line37> > > > > Just out of curiosity, is there any advantage of making it a member > > variable instead of just initializing it in the function?
you save lines of code and unittests focusing what he realy do - Felix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119459/#review63120 ----------------------------------------------------------- On Juli 25, 2014, 10:41 vorm., Felix Eisele wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119459/ > ----------------------------------------------------------- > > (Updated Juli 25, 2014, 10:41 vorm.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Added some Unittest for FileMonitor > > > Diffs > ----- > > src/file/autotest/filemonitortest.h 9a72813 > src/file/autotest/filemonitortest.cpp 19d8f85 > > Diff: https://git.reviewboard.kde.org/r/119459/diff/ > > > Testing > ------- > > > Thanks, > > Felix Eisele > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
