----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118448/ -----------------------------------------------------------
(Updated Aug. 17, 2014, 11:34 a.m.) Review request for Baloo, Localization and Translation (l10n) and Alexander Potashev. Changes ------- Delete the KCalendarSystem instance when it is not needed anymore, in order not to leak it. Repository: baloo Description ------- The query parser made the erroneous assumption that each language uses at most one calendar system, and therefore used i18nc to translate the month and day names recognized by the parser. This patches changes that and uses the KCalendarSystem of the user to get the month and day names. I've written the code by looking at how the gregorian, hebrew and islamic calendars work (these are the three that I somehow understand). The idea is to try to get as many days and months as possible, by incrementing an index until the calendar system returns NULL strings. This works well for days, but monthName() requires a year, that is used by some calendar systems to rename/add months on leap years. I pass the current year, as most of the users will look for dates not too far in the future nor in the past. Is there a mean to get the complete list of month names and their corresponding number, using KCalendarSystem or anything else? Diffs (updated) ----- src/queryparser/pass_periodnames.h 1d7d522 src/queryparser/pass_periodnames.cpp 14fa850 Diff: https://git.reviewboard.kde.org/r/118448/diff/ Testing ------- The query parser testsuite still passes, and properly gets the name of Gregorian months and days (the tests run using the C locale). Thanks, Denis Steckelmacher
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
