----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119789/#review64688 -----------------------------------------------------------
Nice work. Just out of curiosity, is this something you need or is just a simple bug to fix? Also, maybe we should be adding a unit test for this. src/file/basicindexingjob.h <https://git.reviewboard.kde.org/r/119789/#comment45246> Maybe we should find a better name than 'indexFilenameOnly' cause we are indexing more than the filename. We're indexing type, mimetype, filename and mtime. - Vishesh Handa On Aug. 14, 2014, 4:17 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119789/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 4:17 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Bugs: 334274 and Bug > http://bugs.kde.org/show_bug.cgi?id=334274 > http://bugs.kde.org/show_bug.cgi?id=Bug > > > Repository: baloo > > > Description > ------- > > Option to index only filenames added. Disabled by default. As requested in > bug https://bugs.kde.org/show_bug.cgi?id=334274 > > > Diffs > ----- > > src/file/basicindexingjob.h 93aa1e4 > src/file/basicindexingjob.cpp fedef46 > src/file/basicindexingqueue.cpp 86c39f0 > src/file/extractor/app.cpp e3a6ca0 > src/file/fileindexerconfig.h f37bb69 > src/file/fileindexerconfig.cpp 4d2dc52 > > Diff: https://git.reviewboard.kde.org/r/119789/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
