> On Aug. 19, 2014, 3:07 p.m., Vishesh Handa wrote: > > CMakeLists.txt, line 1 > > <https://git.reviewboard.kde.org/r/119843/diff/1/?file=306441#file306441line1> > > > > Won't this need to be changed?
no cmake 2.8 is still fine - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119843/#review64859 ----------------------------------------------------------- On Aug. 19, 2014, 3:21 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119843/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2014, 3:21 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > use standard method to set versions in Plasma packages. also set versions > for tools for good measure > > > Diffs > ----- > > CMakeLists.txt b64a15d > src/file/CMakeLists.txt c3156ac > src/file/main.cpp a9c8be8 > src/tools/balooctl/CMakeLists.txt 8e5f1b7 > src/tools/balooctl/main.cpp 839221c > src/tools/baloosearch/CMakeLists.txt ac9ad59 > src/tools/baloosearch/main.cpp 3b2faa5 > src/tools/balooshow/CMakeLists.txt c0b16c3 > src/tools/balooshow/main.cpp 3f9d461 > > Diff: https://git.reviewboard.kde.org/r/119843/diff/ > > > Testing > ------- > > compiled and installed, libraries all versioned correctly > > > Thanks, > > Jonathan Riddell > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
