----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123721/ -----------------------------------------------------------
(Updated May 11, 2015, 3:27 p.m.) Review request for Baloo and Vishesh Handa. Repository: kfilemetadata Description ------- Removed virtual and added Q_DECL_OVERRIDE to each extractors mimetypes and extract function. Diffs ----- src/extractors/epubextractor.h 1209c36 src/extractors/exiv2extractor.h eecbb5f src/extractors/ffmpegextractor.h 9a18c93 src/extractors/mobiextractor.h 3866f07 src/extractors/odfextractor.h 7b7d55c src/extractors/office2007extractor.h 39d33c6 src/extractors/officeextractor.h 17ae1a4 src/extractors/plaintextextractor.h 311fa8c src/extractors/poextractor.h 7e8787a src/extractors/popplerextractor.h 6a4bea2 src/extractors/taglibextractor.h 354ded7 Diff: https://git.reviewboard.kde.org/r/123721/diff/ Testing ------- make test failed on Test #7 Thanks, John Freeman
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
