----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/#review84070 -----------------------------------------------------------
Ship it! Looks great! Thanks for debugging this and providing a patch. - Vishesh Handa On Aug. 18, 2015, 7:32 p.m., Ashish Bansal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124794/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 7:32 p.m.) > > > Review request for Baloo, Bhushan Shah and Vishesh Handa. > > > Bugs: 350247 > http://bugs.kde.org/show_bug.cgi?id=350247 > > > Repository: baloo > > > Description > ------- > > Earlier two Database instances were being created and once one of them was > destroyed, it leads to invalidation of handles of other instance too. Now a > global single instance is being created and is destroyed when process ends. > > > Diffs > ----- > > autotests/unit/lib/CMakeLists.txt 871bf8d > autotests/unit/lib/db.cpp af34025 > autotests/unit/lib/filefetchjobtest.cpp 2d53c8c > src/engine/CMakeLists.txt 109c19e > src/engine/database.h 1556f0a > src/engine/database.cpp 9dd7327 > src/engine/global.h PRE-CREATION > src/engine/global.cpp PRE-CREATION > src/file/extractor/app.h 2c1ca4e > src/file/extractor/app.cpp 1575f05 > src/file/extractor/main.cpp 3dfb28d > src/file/main.cpp bd162a7 > src/lib/CMakeLists.txt 7bf52e0 > src/lib/db.h 4b87345 > src/lib/db.cpp c9a11f2 > src/lib/file.cpp 13dff88 > src/lib/query.cpp 99fb91a > src/lib/searchstore.cpp 0df20b9 > src/lib/taglistjob.cpp 1abe071 > src/tools/baloo-monitor/monitor.cpp e78e287 > src/tools/balooctl/main.cpp 0736b0c > src/tools/balooshow/main.cpp 02af838 > > Diff: https://git.reviewboard.kde.org/r/124794/diff/ > > > Testing > ------- > > Plasma Mediacenter works fine. > > > Thanks, > > Ashish Bansal > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
