> On Sept. 5, 2015, 3:12 p.m., Vishesh Handa wrote: > > Can you please attach some images of how the KCM now looks?
Should I make a new review request with each patch? Or a single one with 3 diffs? > On Sept. 5, 2015, 3:12 p.m., Vishesh Handa wrote: > > kcms/baloo/CMakeLists.txt, line 20 > > <https://git.reviewboard.kde.org/r/125058/diff/1/?file=400369#file400369line20> > > > > You seem to be using 'QStorageInfo' instead of Solid. Why? > > > > Also, if we decide that is what we want to do, it should in a separate > > patch. This patch is large and should be split. > > Ovidiu-Florin BOGDAN wrote: > It is simpler to get the desired information with QStorageInfo, and it is > less error prone. The risk for errors is smaller. > > Also Solid is another dependency. Qt is already there. I cannot separate this cleanly into a separate patch, because this is part of a biger refactorization. > On Sept. 5, 2015, 3:12 p.m., Vishesh Handa wrote: > > kcms/baloo/configwidget.ui, line 43 > > <https://git.reviewboard.kde.org/r/125058/diff/1/?file=400370#file400370line43> > > > > Moving the checkBox from the top to bottom? Why? Also, if we want this > > it goes in a seperate patch. > > Ovidiu-Florin BOGDAN wrote: > I moved it from the bottom to the top. > > Vishesh Handa wrote: > Right, bottom to top. Why? > > Ovidiu-Florin BOGDAN wrote: > It seems to me more logical this way. Here's the screenshot: > http://i.imgur.com/RBWxutv.png Separated into a different patch. > On Sept. 5, 2015, 3:12 p.m., Vishesh Handa wrote: > > kcms/baloo/folderselectionwidget.cpp, line 130 > > <https://git.reviewboard.kde.org/r/125058/diff/1/?file=400372#file400372line130> > > > > Is this change required? > > Ovidiu-Florin BOGDAN wrote: > The name is more descriptive like this. It is less likely to cause > confusion. > > Vishesh Handa wrote: > It is only used in one place, which is **one line** below this. > > Anyway, if you still want to commit this, it goes in a seperate patch. Separated into different patch. - Ovidiu-Florin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/#review84861 ----------------------------------------------------------- On Sept. 5, 2015, 2:33 p.m., Ovidiu-Florin BOGDAN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125058/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2015, 2:33 p.m.) > > > Review request for Baloo, Plasma, Pinak Ahuja, and Vishesh Handa. > > > Repository: plasma-desktop > > > Description > ------- > > Added the functionality to add directories to be indexed. > Did some cleaning up. > > > Diffs > ----- > > kcms/baloo/CMakeLists.txt 7415289 > kcms/baloo/configwidget.ui 512e4a5 > kcms/baloo/folderselectionwidget.h 226ab45 > kcms/baloo/folderselectionwidget.cpp b44d111 > kcms/baloo/kcm.h 6ff5813 > kcms/baloo/kcm.cpp 27d93e2 > > Diff: https://git.reviewboard.kde.org/r/125058/diff/ > > > Testing > ------- > > Tested add, remove include and exclude directories. > > > Thanks, > > Ovidiu-Florin BOGDAN > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
