----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125130/#review85089 -----------------------------------------------------------
Ship it! Looks good, thanks. Not sure which boilerplate code you mean. I would just replace the awful #include <QtDBus/QtDBus> which includes also all of QtCore, and replace it with the #include <QDBusAbstractAdaptor>, but other than that, the rest looks useful to me. - David Faure On Sept. 10, 2015, 7:30 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125130/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2015, 7:30 a.m.) > > > Review request for Baloo, David Faure and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Not sure if I should remove the boilerplate code as well? > > > Diffs > ----- > > src/file/mainadaptor.h bbc5d49 > src/file/mainadaptor.cpp 4f9e95b > > Diff: https://git.reviewboard.kde.org/r/125130/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
