----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125401/#review85958 -----------------------------------------------------------
I had a first look on the code, I'll try to get into the ADS code later. src/xattr_p.h (line 147) <https://git.reviewboard.kde.org/r/125401/#comment59312> qWarning()? src/xattr_p.h (line 210) <https://git.reviewboard.kde.org/r/125401/#comment59313> missing return or unneded cleanup code? - Patrick von Reth On Sept. 25, 2015, 10:43 nachm., Patrick Spendrin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125401/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 10:43 nachm.) > > > Review request for Baloo and kdewin. > > > Repository: kfilemetadata > > > Description > ------- > > I implemented all the functions for storing and retrieving user metadata > using Alternate Data Streams (ADS). > > > Diffs > ----- > > src/extractors/poextractor.h 2929fc1b6e032ceb117efb60ffa05c79b1af0841 > src/extractors/poextractor.cpp a521982e4286155e15dc0270892e56c2b0db0cba > src/usermetadata.cpp 28967287d67d3e15a548a4e3fda614568dc932a3 > src/xattr_p.h 80ea4c7767e5017af92dd5744ed061eedc3c2834 > > Diff: https://git.reviewboard.kde.org/r/125401/diff/ > > > Testing > ------- > > On Windows; since most of the code is ifdeffed anyway, it shouldn't matter > for other platforms > > > Thanks, > > Patrick Spendrin > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
