----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125482/#review86245 -----------------------------------------------------------
src/tools/balooctl/configcommand.cpp (line 86) <https://git.reviewboard.kde.org/r/125482/#comment59443> whether not weather Or you could use 'if'. src/tools/balooctl/configcommand.cpp (line 107) <https://git.reviewboard.kde.org/r/125482/#comment59441> I'm not sure if we should translate yes/no since we do not accept the translated version as input. src/tools/balooctl/configcommand.cpp (line 366) <https://git.reviewboard.kde.org/r/125482/#comment59442> Could you please split this into its own if block and not combine it with 'hidden'. There will be a little bit of duplicaiton, but it will be much easier to understand. - Vishesh Handa On Oct. 2, 2015, 2 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125482/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2015, 2 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > syntax: balooctl config [set|ls] contentIndexing (yes/no) > > > Diffs > ----- > > src/lib/indexerconfig.h 98b51a8 > src/lib/indexerconfig.cpp 86094da > src/tools/balooctl/configcommand.cpp 91f31c2 > > Diff: https://git.reviewboard.kde.org/r/125482/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
