----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128554/ -----------------------------------------------------------
(Updated Aug. 3, 2016, 9:03 p.m.) Status ------ This change has been marked as submitted. Review request for Baloo. Repository: kfilemetadata Description ------- Check for xattr during config step, otherwise the build might fail (if xattr.h is missing). Missing xattr should now trigger an error message to prompt the user into installing libattr + development packages. CMake logic is based on: https://github.com/rpm-software-management/librepo/blob/master/cmake/Modules/FindXattr.cmake Taking some cues from an older KDE review request that Googling turned up: https://git.reviewboard.kde.org/r/115877/ Note: the rationale for this change is purely to 'document'/warn about the previously hidden dependency on xattr when building from source. Currently this is a hard dependency, compilation simply errors out if xattr headers aren't available. Diffs ----- CMakeLists.txt 4ec8eebe54fa8220c30930efffd8e76fd5eb0695 cmake/FindXattr.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128554/diff/ Testing ------- Without xattr development headers cmake now complains when building with kdesrc-build. With xattr development headers installed, cmake & compilation steps pass with kdesrc-build. Thanks, Johan Ouwerkerk
