----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129183/ -----------------------------------------------------------
(Updated Oct. 14, 2016, 9:13 p.m.) Review request for Baloo. Changes ------- Modify IOHandler class to not take the second (unused) argument at all instead ignoring it Repository: baloo Description ------- CLayz warns about an unused member var in IOHandler and a missing Q_OBJECT macro in TimeEstimator which produces a lot of noise in the compile output. Diffs (updated) ----- src/file/extractor/app.cpp 6843165 src/file/extractor/autotests/iohandlertest.cpp 2c8eeaa src/file/extractor/iohandler.h c0dfbbb src/file/extractor/iohandler.cpp b49a2b2 src/file/timeestimator.h 11137d3 Diff: https://git.reviewboard.kde.org/r/129183/diff/ Testing ------- Compiles fine Thanks, Christian Ehrlicher