----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100621 -----------------------------------------------------------
I wouldn't discard it, I'm afraid nobody really wants to take responsibility though. I'd say that if you plan to maintain it you can commit it. - Aleix Pol Gonzalez On Nov. 6, 2016, 12:39 a.m., Christian Ehrlicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129186/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2016, 12:39 a.m.) > > > Review request for Baloo, KDE Frameworks and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This patch speeds up PostingCodec::encode() by a factor of ~4 by not adding > every single encoded int32 to the resulting bytearray which results in a lot > of small memcpy operations. > The idea is to use a preallocated QByteArray and directly encode the integers > into this buffer. This makes the code a little bit more complex but the > speedup should be gain enough for this. > > > Ping! No interest in this patch? Should I discard it? > > > Diffs > ----- > > src/codecs/coding.cpp 5961077 > > Diff: https://git.reviewboard.kde.org/r/129186/diff/ > > > Testing > ------- > > positoncodectest calculates the same md5sum as before. > > > Thanks, > > Christian Ehrlicher > >