----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/#review100797 -----------------------------------------------------------
I don't think this is saving anything, the move constructor should be taking care of it. http://en.cppreference.com/w/cpp/language/move_constructor - Aleix Pol Gonzalez On Nov. 11, 2016, 5:58 p.m., Christian Ehrlicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129378/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 5:58 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > No functional changes, just adding some const & to avoid copies where > possible. > > > Diffs > ----- > > src/engine/transaction.cpp a1e4fe3 > src/engine/writetransaction.cpp 171f5ba > src/file/fileindexscheduler.cpp d50f2be > src/file/pendingfilequeue.cpp 685bf9e > tests/engine/basicindexingtest.cpp 1db4d15 > > Diff: https://git.reviewboard.kde.org/r/129378/diff/ > > > Testing > ------- > > > Thanks, > > Christian Ehrlicher > >
