----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129379/#review100820 -----------------------------------------------------------
Fix it, then Ship it! src/codecs/coding.cpp (line 95) <https://git.reviewboard.kde.org/r/129379/#comment67661> Can you document the method? Somewhat unusual API, given that it writes to both baTmp and dst :) src/codecs/positioncodec.cpp (line 35) <https://git.reviewboard.kde.org/r/129379/#comment67662> typo: missing r before y - David Faure On Nov. 11, 2016, 5:09 p.m., Christian Ehrlicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129379/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 5:09 p.m.) > > > Review request for Baloo and David Faure. > > > Repository: baloo > > > Description > ------- > > As discussed in REVIEW 129186 there is a lot of bit rotting in coding.cpp/.h. > With this patch I removed all the unused stuff and moved out a temporary > buffer to avoid reallocating this buffer on every call to > putDifferentialVarInt32() > > > Diffs > ----- > > src/codecs/coding.h 3d55a40 > src/codecs/coding.cpp 73e2fa2 > src/codecs/positioncodec.cpp 22f4895 > > Diff: https://git.reviewboard.kde.org/r/129379/diff/ > > > Testing > ------- > > Unittests still working as expected > > > Thanks, > > Christian Ehrlicher > >
