----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129349/#review101376 -----------------------------------------------------------
+1 src/file/fileindexerconfig.h (line 119) <https://git.reviewboard.kde.org/r/129349/#comment67874> You need to duplicate the API documentation. src/file/fileindexerconfig.cpp (line 188) <https://git.reviewboard.kde.org/r/129349/#comment67875> Make this one call the `QStringRef` variant, not to duplicate code? - Aleix Pol Gonzalez On Nov. 6, 2016, 2:45 p.m., Christian Ehrlicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129349/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2016, 2:45 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > Use the new QStringRef class to avoid creation of temporary QString objects. > Since every filename is sent through > FileIndexerConfig::shouldFileBeIndexed(), I think this is a good optimization > although now there are two functions for > FileIndexerConfig::shouldFileBeIndexed() and RegExpCache::exactMatch() - one > with QString and one with QStringRef ... > > > Diffs > ----- > > src/engine/queryparser.cpp d096bf3 > src/file/fileindexerconfig.h 10eacd5 > src/file/fileindexerconfig.cpp 0e4f4c4 > src/file/modifiedfileindexer.cpp d1f5011 > src/file/newfileindexer.cpp 7e19622 > src/file/regexpcache.h 60d370d > src/file/regexpcache.cpp 61f07d6 > src/file/xattrindexer.cpp 3daecef > src/kioslaves/tags/kio_tags.cpp de2e6d7 > > Diff: https://git.reviewboard.kde.org/r/129349/diff/ > > > Testing > ------- > > > Thanks, > > Christian Ehrlicher > >
