On 28.02.2018 20:44, Nicolás Alvarez wrote:
2018-02-28 6:57 GMT-03:00 Michael Heidelbach <ottw...@gmail.com>:
Hi!
Now that I saw https://phabricator.kde.org/D10905, I want to do something
similar for baloo and baloo-widgets.
I'd really like to that once and for all. Because applying coding style
on-the-fly obscures real changes introduced.
1. Would it be reasonable?
2. Who would be willing to review such a huge diff?
3. How to apply KDE coding style most effectively?
(The astyle command given in Kdelibs Coding Style does not produce
completely correct results:
[this](const QUrl &url) => [this](const QUrl & url) instead of
[this](const QUrl& url)
Also the operators-at-beginning-of-line rule is not respected )
4. What about arcanist: any ready-made .arclint available?
Cheers,
Michael
Just one suggestion: Provide the settings and version number of the
tool you used, both in the review and in the commit message, so that
other people can reproduce the exact same result.
Artistic Style Version 2.05.1
astyle --indent=spaces=4 --style=linux \
--indent-labels --pad-oper --unpad-paren --pad-header \
--keep-one-line-statements --convert-tabs \
--indent-preprocessor \
`find -type f -name '*.cpp' -or -name '*.cc' -or -name '*.h'`
as described here
<https://community.kde.org/Policies/Kdelibs_Coding_Style#Artistic_Style_.28astyle.29_automatic_code_formatting>
