Thanks for the advice. I'll do that for both dolphin-plugins MR as I feel they are ready to be reviewed.
Best regards, Kwon-Young Choi On 8/18/20 12:00 PM, Albert Astals Cid wrote: > El diumenge, 16 d’agost de 2020, a les 18:15:27 CEST, Kwon-Young Choi va > escriure: >> Hello, >> >> I was very excited to find out that the MountIso plugin I contributed to >> dolphin was officially released: >> https://kde.org/announcements/releases/2020-08-apps-update/ >> >> However, there is still some work to do to improve the code and user >> experience of the plugin. >> I made some merge requests on gitlab: >> >> * https://invent.kde.org/sdk/dolphin-plugins/-/merge_requests/8 >> * https://invent.kde.org/sdk/dolphin-plugins/-/merge_requests/2 >> * https://invent.kde.org/frameworks/solid/-/merge_requests/10 >> >> But they still need to be reviewed and improved. >> I would be very grateful if anybody could look at them and give some >> feedback on what I should do next. > I would suggest you remove the WIP: from the subject, at least for me, WIP > means "I am still working on this, i've just uploaded it to not lose it if my > HD crashes, or to see the CI run (if there's one), etc." So I usually ignore > WIP: Merge Requests, it's not like i actually look at dolphin-plugins or > solid MR usually anyway, but may be a similar issue for other people. > > Cheers, > Albert > >> Thanks for your help! >> >> Kwon-Young Choi >> >> > > >
