Currently Solaris only supports SIOCGIFHWADDR on PF_PACKET sockets, so even if the compile time error went away, a run time error would be introduced. KDE needs to be smarter about when it configures PF_PACKET for use.
Liu Siwei wrote: > This header change is due to the push of > > PSARC/2009/232 Solaris Packet Capture > > You may contact the responsible engineer Darren Reed for more > informations and/or resolution. > > > Cheers, > Siwei > > > On Mon, Oct 26, 2009 at 5:07 AM, Pavel Heimlich <tropikhajma at gmail.com > <mailto:tropikhajma at gmail.com>> wrote: > > Hi, > a piece of code introduced into KDE 3 years ago to fix build on > Solaris (http://bugs.kde.org/show_bug.cgi?id=124469) assumes that > if SIOCGIFHWADDR is defined, ifru_hwaddr is available. > > However sockio.h now defines SIOCGIFHWADDR > > (http://src.opensolaris.org/source/diff/onnv/onnv-gate/usr/src/uts/common/sys/sockio.h?r2=%252Fonnv%252Fonnv-gate%252Fusr%252Fsrc%252Futs%252Fcommon%252Fsys%252Fsockio.h%4010639%3A368f1335a058&r1=%252Fonnv%252Fonnv-gate%252Fusr%252Fsrc%252Futs%252Fcommon%252Fsys%252Fsockio.h%4010616%3A3be00c4a6835 > > <http://src.opensolaris.org/source/diff/onnv/onnv-gate/usr/src/uts/common/sys/sockio.h?r2=%252Fonnv%252Fonnv-gate%252Fusr%252Fsrc%252Futs%252Fcommon%252Fsys%252Fsockio.h%4010639%3A368f1335a058&r1=%252Fonnv%252Fonnv-gate%252Fusr%252Fsrc%252Futs%252Fcommon%252Fsys%252Fsockio.h%4010616%3A3be00c4a6835>), > yet net/if.h (or any other file) does not provide ifru_hwaddr. > > This piece of code > > (http://websvn.kde.org/trunk/KDE/kdebase/apps/kinfocenter/nics/nic.cpp?view=log) > is now broken due to that change. > > Who's to blame? :-) > should osol now provide ifru_hwaddr? > or should the KDE code change? if so, what defines should be expected? > > TIA for hints > -- > This message posted from opensolaris.org <http://opensolaris.org> > _______________________________________________ > kde-discuss mailing list > kde-discuss at opensolaris.org <mailto:kde-discuss at opensolaris.org> > http://mail.opensolaris.org/mailman/listinfo/kde-discuss > >
