I have included a new module for review before I start integrating it.

There are some issues in consistency that we should probably address
since I would be inclined to "%include base-os-selection.inc" in
base-foss-header.inc.  However, there is no base-kde-header.inc,
and it appears that most of that information is contained in the
KDEhier.spec file.

In the short term, things which do not include base-foss-header.inc
should include base-os-selection.inc, especially if foss-depend-packages.inc
is included.

basically, there's are just a bunch of boolean (is_<X>, not_<X>)
which will make conditional builds work better (such as the current
problem with strigi......)

For Open Solaris, the version is contained within %{if_osoldev} if
%{is_osol} is true (1), so conditional tests could be something like:

%if %( test %{is_osol} -eq 1 -a %{if_osoldev} -gt 129 && echo 1 || echo 0)

if you wanted to test for an open solaris release greater than 129.

please review.

Thanks,

Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: base-os-selection.inc
Type: application/octet-stream
Size: 1916 bytes
Desc: not available
URL: 
<http://mail.opensolaris.org/pipermail/kde-discuss/attachments/20100101/3da440d0/attachment.obj>

Reply via email to