There is was a comment in FOSSphonon.spec which dates back to Dude:

Probably appropriate if we can get this to link with xine

There was a problem where phonon xine video widget would not build, which
I fixed.  After fixing it, I tried to make the xine video widget support
in phonon optional (diffs are below for my failed attempt), however it failed
with (this build was after I did: pkgrm FOSSxine-lib):

pkgbuild: --   package 'libxine' not found
pkgbuild: CMake Error at cmake/FindXine.cmake:35 (macro_ensure_version):
pkgbuild:   MACRO_ENSURE_VERSION Macro invoked with incorrect arguments for 
macro
pkgbuild:   named: MACRO_ENSURE_VERSION
pkgbuild: Call Stack (most recent call first):
pkgbuild:   cmake/MacroOptionalFindPackage.cmake:19 (FIND_PACKAGE)
pkgbuild:   xine/CMakeLists.txt:30 (macro_optional_find_package)
pkgbuild: 
pkgbuild: 
pkgbuild: -- checking for module 'xcb'
pkgbuild: --   found xcb, version 1.1.93
pkgbuild: -- Cannot compile VideoWidget for the xine backend. Needs xine 
version 1.1.9 or later and libxcb.
pkgbuild: -- 
pkgbuild: 
-----------------------------------------------------------------------------
pkgbuild: -- The following external packages were located on your system.
pkgbuild: -- This installation will have the extra features provided by these 
packages.
pkgbuild: + GLib2
pkgbuild: + GStreamer
pkgbuild: + GStreamer video plugin
pkgbuild: + GStreamer audio plugin
pkgbuild: + GLib2
pkgbuild: + LibXml2
pkgbuild: + OpenGL
pkgbuild: 
-----------------------------------------------------------------------------
pkgbuild: -- The following OPTIONAL packages could NOT be located on your 
system.
pkgbuild: -- Consider installing them to enable more features from this 
software.
pkgbuild: + PulseAudio: A cross-platform, networked sound server. 
<http://www.pulseaudio.org>
pkgbuild: Allows audio playback via the PulseAudio soundserver when it is 
running
pkgbuild: + XCB: XCB is needed for the video widget, libxine needs to be 
compiled with XCB <http://xcb.freedesktop.org/>
pkgbuild: + Xine: libxine is needed to compile phonon xine backend 
<http://xinehq.de/>
pkgbuild: 
-----------------------------------------------------------------------------
pkgbuild: 
pkgbuild: -- Configuring incomplete, errors occurred!
pkgbuild: Bad exit status from /var/tmp/pkgbuild-mwright/pkgbuild-tmp-1.12171 
(%prep)
--- command output ends --- finished at Fri Feb 19 10:11:09 EST 2010

INFO: pkgbuild -ba finished at Fri Feb 19 10:11:09 EST 2010

ERROR: phonon FAILED
INFO: Check the build log in /h/goanna/2/os_5.10/kt/build-logs/FOSSphonon.log 
for details

In order to make it build, at the moment I have added a dependency: FOSSphonon
now depends on FOSSxine-lib, then it builds fine on Solaris 10u8 (its currently
building on OpenSolaris).

Thanks Mark

================================================================================
The failed attempt to make xine video widget optional, not committed.
Note: the chunk the icons should be below %files, it is in r1957.
To see what I really did commit:
hg diff -r 1956 -r 1957
================================================================================

diff -r 824f5d82f181 specs/FOSSphonon.spec
--- a/specs/FOSSphonon.spec     Thu Feb 18 13:21:06 2010 -0500
+++ b/specs/FOSSphonon.spec     Fri Feb 19 11:10:57 2010 +1100
@@ -24,8 +24,12 @@
 Url:                    http://phonon.kde.org/
 Group:                  System/Libraries
 
+%define option_with_multi_media %{?_with_multi_media:1}%{?!_with_multi_media:0}
+%define provide_xine_video_widget %(pkginfo -q FOSSxine-lib && echo 1 || echo 
0)
 
-
+%if %option_with_multi_media
+BuildRequires:         FOSSxine-lib
+%endif
 BuildRequires:         FOSSqt,%{depend_stdcxx}
 BuildRequires:          %{depend_gstreamer}
 BuildRequires:          FOSSautomoc
@@ -50,15 +54,16 @@
 %include base-foss-common.inc
 
 # Probably appropriate if we can get this to link with xine
-#%if %_is_phonon_4_2
-#%{_datadir}/icons/oxygen/scalable/apps/phonon-xine.svgz
-#%{_datadir}/icons/oxygen/16x16/apps/phonon-xine.png
-#%{_datadir}/icons/oxygen/32x32/apps/phonon-xine.png
-#%{_datadir}/icons/oxygen/22x22/apps/phonon-xine.png
-#%{_datadir}/icons/oxygen/64x64/apps/phonon-xine.png
-#%{_datadir}/icons/oxygen/48x48/apps/phonon-xine.png
-#%{_datadir}/icons/oxygen/128x128/apps/phonon-xine.png
-#%endif
+%if %provide_xine_video_widget
+%{_datadir}/kde4/services/phononbackends/xine.desktop
+%{_datadir}/icons/oxygen/22x22/apps/phonon-xine.png
+%{_datadir}/icons/oxygen/64x64/apps/phonon-xine.png
+%{_datadir}/icons/oxygen/128x128/apps/phonon-xine.png
+%{_datadir}/icons/oxygen/32x32/apps/phonon-xine.png
+%{_datadir}/icons/oxygen/48x48/apps/phonon-xine.png
+%{_datadir}/icons/oxygen/16x16/apps/phonon-xine.png
+%{_datadir}/icons/oxygen/scalable/apps/phonon-xine.svgz
+%endif
 
 %files
 %defattr (-, root, bin)
@@ -179,6 +184,9 @@
 %{_libdir}/libphononexperimental.so
 %{_libdir}/libphononexperimental.so.4
 %{_libdir}/libphononexperimental.so.4.4.0
+%if %provide_xine_video_widget
+%{_libdir}/kde4/plugins/phonon_backend/phonon_xine.so
+%endif
 %{_libdir}/pkgconfig/phonon.pc
 
 %if %{has64}
@@ -189,9 +197,14 @@
 %{_libdir}/%{_arch64}/libphononexperimental.so
 %{_libdir}/%{_arch64}/libphononexperimental.so.4*
 %{_libdir}/%{_arch64}/pkgconfig/phonon.pc
+%if %provide_xine_video_widget
+%{_libdir}/%{_arch64}/kde4/plugins/phonon_backend/phonon_xine.so
+%endif
 %endif
 
 %changelog
+* Fri Feb 19 2009 - markwright at internode.on.net
+- Build with Xine XCB video widget
 * Fri Nov 20 2009 - bentaylor.solx86 at gmail.com
 - pure spec-ified
 * Sun Aug 3 2008 - groot at kde.org

Reply via email to