Am Sonntag, 30. Mai 2010, um 14:57:25 schrieb Dennis Nienh?ser: > Hi Burkhard, > > thanks for the quick reply. > > On 30.05.2010 13:53, Burkhard L?ck wrote: > > Hi Dennis, > > > > am Sonntag, 30. Mai 2010, um 10:54:53 schrieb Dennis Nienh?ser: > >> Hi, > >> > >> I wrote two new chapters for the Marble handbook describing the new (in > >> KDE 4.5) download region and routing features. Please review and commit. > >> Would be great if someone could add my name and email address to the > >> global list of entities as well. The patch for index.docbook is attached > >> (base path of the diff is trunk/KDE/kdeedu/doc/marble), the graphics can > >> be downloaded at [1]. The processed handbook in html format can be seen > >> at [2], chapter 5 and 7 are new. > > > > Excellent work, besides some typo fixes this is ok. > > > > Problem could arise adding your name entity to kdelibs now and using it > > immediately in the documentation. > > That means marble's documentation can't be build with kdelibs< 4.5. > > Maybe add me to kdelibs but not use the entity in the Marble handbook > for now then. > Done that.
> > Some minor issues: > > > > * any reason for the blue border around some screenshots (download- > > region-3.png, routing-[1-3].png)? > > I followed a suggestion for the kde.org website here: Screenshots should > include a bit of "context" from the default wallpaper. This looks better > than cutting it off at the window margins because the rounded corners > and drop shadow of the default theme are not destroyed. No strong > opinion on it; I can shrink them if you want to. > You refer to this site: http://l10n.kde.org/docs//screenshots.php ? Hmm, afaik I've never seen screenshots with "context" from the default wallpaper. But that is nonrelevant. > > * plugins settings: > > Amateur Radio Aprs Plugin, ExternalDraw, GeoRenderer Plugin, Download > > Progress Indicator, Wheather are not in the documentation or commented > > out, are these plugins enabled in released version and should be added? > > > > File view Plugin is gone and has to be removed from the documentation? > > Good point, I updated the screenshot (tar file on my website is updated) > and the section to match the current plugins. Updated patch is attached. > File View is not fully gone, but not included in releases either. > > > Btw the ExternalDraw plugin has at least one i18n bug and is > > untranslatble (https://bugs.kde.org/show_bug.cgi?id=239843) > > The external draw plugin is maintained by digikam and only included in > Marble if digikam is installed. I don't think it should be mentioned in > the handbook. > Committed to trunk + 4.5, thank you Dennis. -- Burkhard L?ck
