----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128086/#review96163 -----------------------------------------------------------
Ship it! Looks good as a first step to cleanup it. Answering some of the FIXMEs: 1) I guess that, instead of the Sourceforge references, we could point to: https://www.kde.org/applications/multimedia/kaffeine/. That page should be updated too... In special, it doesn't give any credits to the original Kaffeine authors, and mentions the author that moved the code from SF to KDE as if he was the only author. 2) The only backend currently enabled is VLC. the mplayer backend is currently disabled. So, there's no menu to select the backend; 3) The old DCOP interface was replaced by QMessageBus. It seems that the conversion was based on this document: https://techbase.kde.org/Development/Tutorials/Porting_to_D-Bus. So, the API calls documented there should be changed. I didn't test to see if it is still working, but I guess it should work fine. 4) I guess we can remove the emacs macros at the end of the docbook file too. - Mauro Carvalho Chehab On June 3, 2016, 2:31 p.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128086/ > ----------------------------------------------------------- > > (Updated June 3, 2016, 2:31 p.m.) > > > Review request for Documentation and Mauro Carvalho Chehab. > > > Repository: kaffeine > > > Description > ------- > > remove all superfluous comments > use entity kaffeine > add a lot of FIXME's with questions + hints what needs to be checked/updated > nor ready for production > > > Diffs > ----- > > doc/index.docbook 8d8a73e > > Diff: https://git.reviewboard.kde.org/r/128086/diff/ > > > Testing > ------- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
_______________________________________________ kde-doc-english mailing list kde-doc-english@kde.org https://mail.kde.org/mailman/listinfo/kde-doc-english
