ngraham added a comment.

  All right, you've convinced me on the shortcut.
  
  The way you've implemented the menu item naming seems a bit fragile though 
(and in line 1410 of `src/dolphinmainwindow.cpp`, it's not used at all). In my 
testing, the name doesn't show up and it falls back to the static name. If you 
can't find a way to implement the feature reliably, it may be best to just 
always show static text. But it would be nice to have the name of the app 
reliably show up there, though.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, 
feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, 
emmanuelp, mikesomov

Reply via email to