On Thursday 08 March 2012 18:08:15 Stephen Kelly wrote: > David Faure wrote: > > On Thursday 08 March 2012 13:11:37 Giorgos Tsiapaliwkas wrote: > >> This is my patch about moving kdialog to staging/kwidgets but I need to > >> link to > >> KGuiItem(KDialog requires that). I can do then job, but there was nobody > >> in the channel to approve it. So I didn't. > > > > This KDialog move looks good. > > > > KGuiItem should move to kguiaddons I think. > > Which means moving KIcon and KIconLoader/KIconTheme too (KGuiItem depends > > on it). > > > > Right Steve? We said we would keep KIcon/KIconLoader --> kguiaddons ? > > Well, considering that QIcon is in QWidgets, there's a widgets dependency > anyway.
Oh? It didn't land in QtGui after all? :-/
> Is KGuiAddons supposed to be widgets-free?
That was the intent yes.
> We did say we'd keep the KIcon{Loader,Engine,Theme} stuff, yes. Whether we
> deprecate the KIcon class or replace it with methods in a namespace, I'm not
> sure.
I'd be in favor of replacing it with factory methods in a namespace indeed.
That's really all there is to it.
Regards.
--
Kévin Ottens, http://ervin.ipsquad.net
KDAB - proud patron of KDE, http://www.kdab.com
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
