On Monday 06 August 2012 13:53:08 Jeremy Whiting wrote: > I didn't check the make test against the result you are getting on the main > branch, no. I'll remove the KAboutData from these and check that. Some of > these KAboutData have quite a bit in them, is it ok to nuke them?
Don't nuke those that have an actual list of authors. But most of them are just a fake kaboutdata just because there needed to be one. > I also found one KApplication usage in an io slave that's part of the > patch, is that ok to port to QApplication? or is there something that > KApplication brings that it needs (does kquitapp blah work on QApplications > for example)? KApplication brought dbus registration, indeed. As documented in KDE5PORTING.html, you have to add a call to KDBusService in order to get that with QApplication. Most (if not all) unittests don't need that, though. KIOSlaves themselves don't register to DBus, though. The KApplication usage in ioslaves was for an event loop, right? Ah it's old kio_metainfo. I'm pretty sure a QCoreApplication is enough there. Thanks, -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
