On 2012-11-19, Stephen Kelly <steve...@gmail.com> wrote: >> I don't have a link to 'you should not inherit sonames from other >> modules'. but it sholud kind of be common sense as we also see in >> various areas of current KDE land where e.g. libkmailprivate from kdepim >> 4.4 is not having a matching SONAME, but gets the SONAME from the >> kdelibs it is built against. > > I think I misread what you wrote before. You meant 'kde modules', not 'ecm > modules' AKA cmake files or macros.
No. I actually meant do not inherit SONAME from anywhere. including another kde module or a ecm module or cmake. > I'm not opposed to changing that (I think Alex wrote a replacement macro > already), but I don't think just renaming the macro makes it more > discoverable. If you didn't know the macro existed you'd still just be > looking at a '${FOO_VERSION}' that comes from somewhere and start looking > for a use of a macro with version in the name. I agree that it is not a prefect fix, but definately a improvement. It also helps to show that it originates *somewhere* inside this directory structure and not somewhere else. > Anyway - Yes, the ecm API is not perfect yet and not ready for consumption > by anyone yet. That will come though and I don't think it's something we > need to spend a lot of time worrying about or discussing just yet. We do need to start to actually use it at least amongst powerusers to ensure that we can actually commit to a nice source compatibility once we are at a release. /Sune _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel