----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107911/#review23983 -----------------------------------------------------------
knewstuff/knewstuff3/CMakeLists.txt <http://git.reviewboard.kde.org/r/107911/#comment18264> Don't duplicate the full list of libs. Call target_link_libraries once with all the non-optional libs, and then call it again inside an if(), with attica as argument. target_link_libraries is cumulative, it can be called multiple times. - David Faure On Dec. 25, 2012, 8:26 p.m., Valentin Rusu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107911/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2012, 8:26 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > For the moment Attica won't build with QT5, so it won't install in a KF5/QT5 > setup. > This fix let KF5/QT5 build without Attica. > > > Diffs > ----- > > CMakeLists.txt e5ef86e > knewstuff/knewstuff3/CMakeLists.txt 8653433 > > Diff: http://git.reviewboard.kde.org/r/107911/diff/ > > > Testing > ------- > > > Thanks, > > Valentin Rusu > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
