----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107791/ -----------------------------------------------------------
(Updated Feb. 10, 2013, 8:40 p.m.) Review request for KDE Frameworks, kdelibs and David Faure. Changes ------- fix issues raised so far, and also move UI parts out of kdeui. Summary (updated) ----------------- move Sonnet out of KDEUI, port away from KDE classes. Description ------- Ported everything away from KConfig to QSettings. I couldn't really find any users of the ::save function, so I think the source incompatible change would be worth it. Alternatively we could add a deprecated dummy function that takes in a KConfig object and just ignores it, and uses QSettings. Diffs (updated) ----- kdeui/CMakeLists.txt 08faa20 kdeui/sonnet/configdialog.h 4c05f0d kdeui/sonnet/configdialog.cpp af3f9b4 kdeui/sonnet/configui.ui 11dffc0 kdeui/sonnet/configwidget.h 023b659 kdeui/sonnet/configwidget.cpp 549d5af kdeui/sonnet/dialog.h 241bd02 kdeui/sonnet/dialog.cpp 3c6f99f kdeui/sonnet/dictionarycombobox.h 82a807c kdeui/sonnet/dictionarycombobox.cpp 32e0970 kdeui/sonnet/highlighter.h f3bc4af kdeui/sonnet/highlighter.cpp d72b9e0 kdeui/sonnet/sonnetui.ui 03af35b kdeui/sonnet/tests/test_configdialog.cpp 4c4fd21 kdeui/widgets/ktextedit.h d0c1c4d kdeui/widgets/ktextedit.cpp 5bf4741 staging/sonnet/src/CMakeLists.txt 157dfa9 staging/sonnet/src/core/CMakeLists.txt 2f11dc0 staging/sonnet/src/core/backgroundchecker.h f0da3a3 staging/sonnet/src/core/backgroundchecker.cpp dc05b94 staging/sonnet/src/core/globals.cpp bf4f504 staging/sonnet/src/core/loader.cpp bfa56a9 staging/sonnet/src/core/settings.cpp e405c30 staging/sonnet/src/core/settings_p.h e14bad7 staging/sonnet/src/core/speller.h 37dd82f staging/sonnet/src/core/speller.cpp 024d7f7 staging/sonnet/src/ui/configdialog.h PRE-CREATION staging/sonnet/src/ui/configdialog.cpp PRE-CREATION staging/sonnet/src/ui/configui.ui PRE-CREATION staging/sonnet/src/ui/configwidget.h PRE-CREATION staging/sonnet/src/ui/configwidget.cpp PRE-CREATION staging/sonnet/src/ui/dialog.h PRE-CREATION staging/sonnet/src/ui/dialog.cpp PRE-CREATION staging/sonnet/src/ui/dictionarycombobox.h PRE-CREATION staging/sonnet/src/ui/dictionarycombobox.cpp PRE-CREATION staging/sonnet/src/ui/highlighter.h PRE-CREATION staging/sonnet/src/ui/highlighter.cpp PRE-CREATION staging/sonnet/src/ui/sonnetui.ui PRE-CREATION staging/sonnet/tests/CMakeLists.txt 11d32e6 staging/sonnet/tests/test_dialog.h 583b27b Diff: http://git.reviewboard.kde.org/r/107791/diff/ Testing ------- it builds. Thanks, Martin Tobias Holmedahl Sandsmark
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel