----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109019/ -----------------------------------------------------------
(Updated Feb. 20, 2013, 10:32 p.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Changes ------- Here is the updated patch. I solved many of the issues you shown. I also moved the globalShortcutChanged signal from KAction to KGlobalAccel. Several issues was centered around the const KAction* semantics of KGlobalAccel's methods. Letting alone that current code also had these const qualifiers, this new KGlobalAccel implementation no longer modifies KAction state. This should be clearly stated in our API using this const qualifier. So I prefered to (gently "sauf respect") drop these issues. :-) Description ------- KDELibs cleanup task: move global shortcut facilities from KAction to KGlobalAccel. The second step, registering QActions instead of KActions, will be done after completing this review. Diffs (updated) ----- kdeui/tests/kglobalshortcuttest.cpp 49fb8ec kdeui/actions/kaction.h ddaa4de kdeui/actions/kaction.cpp ec63a72 kdeui/actions/kaction_p.h b50e678 kdeui/actions/kactioncollection.cpp 555b204 kdeui/dialogs/kshortcutseditoritem.cpp 5aa8437 kdeui/shortcuts/kglobalaccel.h ed68bba kdeui/shortcuts/kglobalaccel.cpp 36dbab7 kdeui/shortcuts/kglobalaccel_p.h 04feaba Diff: http://git.reviewboard.kde.org/r/109019/diff/ Testing ------- Code compiles Thanks, Valentin Rusu
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
