----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110477/#review32874 -----------------------------------------------------------
staging/kde4attic/tests/CMakeLists.txt <http://git.reviewboard.kde.org/r/110477/#comment24388> Should go in autotests, not tests. We have autotests folders for the unit tests, and tests folders for the manual tests. - Kevin Ottens On May 16, 2013, 6:28 p.m., Anne-Marie Mahfouf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110477/ > ----------------------------------------------------------- > > (Updated May 16, 2013, 6:28 p.m.) > > > Review request for KDE Frameworks and Kevin Ottens. > > > Description > ------- > > Move KTimeComboBox to KDE4Attic > Move test: it was in KDEUI Unit Tests but there's no such section in the > staging/kde4attic/tests/CMakeLists.txt so it's now in executable which might > be wrong. > > > Diffs > ----- > > kdeui/CMakeLists.txt cfa29ef > kdeui/tests/CMakeLists.txt cd055d5 > kdeui/tests/ktimecomboboxtest.h 793bffb > kdeui/tests/ktimecomboboxtest.cpp 4aaadef > kdeui/widgets/ktimecombobox.h 21094b2 > kdeui/widgets/ktimecombobox.cpp e1a9322 > kdewidgets/kde.widgets aa07c0f > kdewidgets/kdedeprecated.widgets 3adc0b2 > staging/kde4attic/src/CMakeLists.txt 2fe1b8c > staging/kde4attic/src/ktimecombobox.h PRE-CREATION > staging/kde4attic/src/ktimecombobox.cpp PRE-CREATION > staging/kde4attic/tests/CMakeLists.txt 1305d63 > staging/kde4attic/tests/ktimecomboboxtest.h PRE-CREATION > staging/kde4attic/tests/ktimecomboboxtest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110477/diff/ > > > Testing > ------- > > It builds > > > Thanks, > > Anne-Marie Mahfouf > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
