> On May 29, 2013, 11:50 a.m., David Faure wrote: > > Apar from the KConfigDialogManager issue below, it looks good. However, > > please wait until next week to commit it, to give people time to update > > their qt5.git build, since you use new API from there > > (QSpinBox::setDisplayIntegerBase). I promised Aaron that the use of new API > > in Qt would only happen after the first monday after the qt5 update.
I'll wait until next Monday evening. > On May 29, 2013, 11:50 a.m., David Faure wrote: > > kdeui/dialogs/kconfigdialogmanager.cpp, line 146 > > <http://git.reviewboard.kde.org/r/110418/diff/2/?file=146814#file146814line146> > > > > Do we need to register KIntNumInput into KConfigDialogManager "from the > > outside", i.e. from a Q_CONSTRUCTOR_FUNCTION in kintnuminput.cpp > > (kde4support)? > > > > Otherwise existing code with KIntNumInput + KConfigDialogManager will > > break. > > > > I think there were other commits to KConfigDialogManager earlier whicih > > might have the same issue. If there isn't one, we might need to add a > > public method for registering a class and its associated signal. There is no method to register a class. I think it's above my league to add one. Either someone else does it or I go over the moved classes and re-add what was removed. - Anne-Marie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110418/#review33350 ----------------------------------------------------------- On May 28, 2013, 7:45 p.m., Anne-Marie Mahfouf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110418/ > ----------------------------------------------------------- > > (Updated May 28, 2013, 7:45 p.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Ottens. > > > Description > ------- > > Move KNumInput to KDE4Support, use QSpinBox or QDoubleSpinBox instead. > Test moved as well. > > > Diffs > ----- > > kdeui/dialogs/kconfigdialogmanager.cpp 87c3e48 > kdeui/dialogs/kinputdialog.cpp 6cbd881 > kdeui/dialogs/kinputdialog_p.h dcdff3f > kdeui/tests/krulertest.h fc677c6 > kdeui/tests/krulertest.cpp 9686421 > staging/kde4support/src/kdeui/kcolordialog.cpp 041c06a > > Diff: http://git.reviewboard.kde.org/r/110418/diff/ > > > Testing > ------- > > Build tested > > > Thanks, > > Anne-Marie Mahfouf > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
