> On May 21, 2013, 10:35 a.m., Kevin Ottens wrote: > > Hm for the kcupsoptionspageswidget.ui don't we need to also introduce a > > QButtonGroup on the C++ side? So that the radio buttons keep being mutually > > exclusive. > > Anne-Marie Mahfouf wrote: > Radio buttons are autoExclusive by default (from doc) which I verified in > the .ui file. > > kdeui/dialogs/kconfigdialogmanager.cpp will be removed from the commit. > > Another error in the initial patch is that kbuttongrouptest should be > moved to staging/kde4support/autotests/ (and not staging/kde4support/tests) > being initially in KDEUI_UNIT_TESTS.
Good point for the test, you should adjust that too indeed. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110478/#review32875 ----------------------------------------------------------- On May 16, 2013, 7:24 p.m., Anne-Marie Mahfouf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110478/ > ----------------------------------------------------------- > > (Updated May 16, 2013, 7:24 p.m.) > > > Review request for KDE Frameworks and Kevin Ottens. > > > Description > ------- > > Port kcupsoptionspageswidget.ui to QGroupBox (I edited the .ui file in > Designer from Qt5 for this hence the changes) > Move class files > Move test > Change export in header and ad deprecated comment > > > Diffs > ----- > > kdeui/CMakeLists.txt cfa29ef > kdeui/dialogs/kconfigdialogmanager.cpp 405799b > kdeui/dialogs/kcupsoptionspageswidget.ui d2494c7 > kdeui/tests/CMakeLists.txt cd055d5 > kdeui/tests/kbuttongrouptest.h cd9130a > kdeui/tests/kbuttongrouptest.cpp 93dd05e > kdeui/widgets/kbuttongroup.h 5bc89dd > kdeui/widgets/kbuttongroup.cpp c4d918d > kdewidgets/kde.widgets aa07c0f > kdewidgets/kdedeprecated.widgets 3adc0b2 > staging/kde4support/src/CMakeLists.txt a8e0a0c > staging/kde4support/src/kdeui/kbuttongroup.h PRE-CREATION > staging/kde4support/src/kdeui/kbuttongroup.cpp PRE-CREATION > staging/kde4support/tests/CMakeLists.txt 4115688 > staging/kde4support/tests/kbuttongrouptest.h PRE-CREATION > staging/kde4support/tests/kbuttongrouptest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110478/diff/ > > > Testing > ------- > > It builds. > > > Thanks, > > Anne-Marie Mahfouf > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel