----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110876/#review34217 -----------------------------------------------------------
khtml/xml/dom_docimpl.cpp <http://git.reviewboard.kde.org/r/110876/#comment25119> ULong means unsigned long, technically. But ok, for a relative duration, it's unlikely to create issues. But yeah, better choose the same int type everywhere for this "number of seconds". qint64 and toLongLong would be consistent indeed. khtml/xml/dom_docimpl.cpp <http://git.reviewboard.kde.org/r/110876/#comment25118> This if() could now be around the full block. Not much point in duplicating it, and in calculating stuff and not using it. - David Faure On June 11, 2013, 10:10 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110876/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 10:10 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML) > > > Diffs > ----- > > khtml/khtml_part.cpp 7027ceca7d05738e1fe0f808e1c808ddfe8e8df3 > khtml/misc/loader.h 5e9db0f8baef69c7bb146e4bd6c8cefcdbfe09c2 > khtml/misc/loader.cpp c8812755b99f841f6e7b90da8e154810c1f7c23f > khtml/xml/dom_docimpl.cpp 15f491857ebd17ef21a6df8e187ed16052974cca > > Diff: http://git.reviewboard.kde.org/r/110876/diff/ > > > Testing > ------- > > It builds. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel