----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111002/#review34334 -----------------------------------------------------------
Indeed kviewstatesaver.h should go in KDE4Support instead of KConfigWidgets. staging/kconfigwidgets/src/kviewstatemaintainer.h <http://git.reviewboard.kde.org/r/111002/#comment25224> Should be kconfigwidgets_export.h ... I even suspect this line could go completely. staging/kconfigwidgets/src/kviewstatemaintainer.h <http://git.reviewboard.kde.org/r/111002/#comment25225> I'm not sure this line is still needed either. - Kevin Ottens On June 13, 2013, 6:12 p.m., Wojciech Kapuscinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111002/ > ----------------------------------------------------------- > > (Updated June 13, 2013, 6:12 p.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Ottens. > > > Description > ------- > > simple move > > Note. > KViewStateSaver is typedef. lxr says that only one class use KViewStateSaver. > Remove this kviewstatesaver.h header? > > > Diffs > ----- > > staging/kconfigwidgets/src/kviewstatesaver.h PRE-CREATION > staging/kconfigwidgets/src/kviewstatemaintainer.cpp PRE-CREATION > staging/kconfigwidgets/src/kviewstatemaintainer.h PRE-CREATION > staging/kconfigwidgets/src/CMakeLists.txt 534b95d > kdeui/itemviews/kviewstatesaver.h 4384974 > kdeui/itemviews/kviewstatemaintainer.cpp cb788ed > kdeui/itemviews/kviewstatemaintainer.h 5ae9797 > kdeui/CMakeLists.txt 46196b4 > > Diff: http://git.reviewboard.kde.org/r/111002/diff/ > > > Testing > ------- > > it builds and tests all OK > > > Thanks, > > Wojciech Kapuscinski > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel